netdev - Re: [PATCH nf-next,v2 1/2] rhashtable: add rhashtable_lookup_get_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160826121520.GA8729@salvia>
Date:   Fri, 26 Aug 2016 14:15:20 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>, davem@...emloft.net
Cc:     netfilter-devel@...r.kernel.org, tgraf@...g.ch,
        netdev@...r.kernel.org
Subject: Re: [PATCH nf-next,v2 1/2] rhashtable: add
 rhashtable_lookup_get_insert_key()

On Fri, Aug 26, 2016 at 07:27:36PM +0800, Herbert Xu wrote:
> On Thu, Aug 25, 2016 at 04:41:26PM +0200, Pablo Neira Ayuso wrote:
> > This patch modifies __rhashtable_insert_fast() so it returns the
> > existing object that clashes with the one that you want to insert.
> > In case the object is successfully inserted, NULL is returned.
> > Otherwise, you get an error via ERR_PTR().
> > 
> > This patch adapts the existing callers of __rhashtable_insert_fast()
> > so they handle this new logic, and it adds a new
> > rhashtable_lookup_get_insert_key() interface to fetch this existing
> > object.
> > 
> > nf_tables needs this change to improve handling of EEXIST cases via
> > honoring the NLM_F_EXCL flag and by checking if the data part of the
> > mapping matches what we have.
> > 
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Cc: Thomas Graf <tgraf@...g.ch>
> > Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Thanks Herbert!

@David, would you be OK if I get this rhashtable update through
nf-next given that I have a follow up patch that depending on this?
Will be sending a pull request asap so we don't get out of sync.