netdev - Re: [PATCH net-next] drivers/net: Use priority level to printk() calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1472174277.4914.36.camel@perches.com>
Date:   Thu, 25 Aug 2016 18:17:57 -0700
From:   Joe Perches <joe@...ches.com>
To:     citestra <oussamamrkd2@...il.com>, netdev@...r.kernel.org
Cc:     Oussama Markad <markad.oussama@...il.com>
Subject: Re: [PATCH net-next] drivers/net: Use priority level to printk()
 calls

On Fri, 2016-08-26 at 00:22 +0200, citestra wrote:
> Add priority level 'KERN_ERR' to a printk() call
[]
> diff --git a/drivers/net/ethernet/amd/am79c961a.c b/drivers/net/ethernet/amd/am79c961a.c
[]
> @@ -182,7 +182,7 @@ am79c961_ramtest(struct net_device *dev, unsigned int val)
>  	am_readbuffer(dev, 0, buffer, 65536);
>  	for (i = 0; i < 65536; i++) {
>  		if (buffer[i] != val && !error) {
> -			printk ("%s: buffer error (%02X %02X) %05X - ", dev->name, val, buffer[i], i);
> +			printk (KERN_ERR "%s: buffer error (%02X %02X) %05X - ", dev->name, val, buffer[i], i);

			netdev_err(dev, "buffer error etc...", val, ...)