netdev - Re: [PATCH] irda: Fix likely typo in output format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472268207.26978.6.camel@perches.com>
Date:   Fri, 26 Aug 2016 20:23:27 -0700
From:   Joe Perches <joe@...ches.com>
To:     Oleg Drokin <green@...uxhacker.ru>,
        Samuel Ortiz <samuel@...tiz.org>,
        Chunyan Zhang <zhang.chunyan@...aro.org>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irda: Fix likely typo in output format string

(added Chunyan Zhang to cc)

On Fri, 2016-08-26 at 23:14 -0400, Oleg Drokin wrote:
> %ul would print an unsigned with a letter l at the end which does
> not seem to be desired here, on the other hand the value being printed
> is u32 so just drop the l instead of converting to %lu

Fixes: 497ec1f2a086 ("irda: vlsi_ir: Replace timeval with ktime_t")

Thanks Oleg

> diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
[]
> @@ -279,7 +279,7 @@ static void vlsi_proc_ndev(struct seq_file *seq, struct net_device *ndev)
>  		(idev->mode==IFF_SIR)?"SIR":((idev->mode==IFF_MIR)?"MIR":"FIR"));
>  	sec = div_s64_rem(ktime_us_delta(ktime_get(), idev->last_rx),
>  			  USEC_PER_SEC, &usec);
> -	seq_printf(seq, "last rx: %ul.%06u sec\n", sec, usec);
> +	seq_printf(seq, "last rx: %u.%06u sec\n", sec, usec);
>  
>  	seq_printf(seq, "RX: packets=%lu / bytes=%lu / errors=%lu / dropped=%lu",
>  		ndev->stats.rx_packets, ndev->stats.rx_bytes, ndev->stats.rx_errors,