lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <041aebd0-7ecc-f407-57d0-ad6a235f323e@gmx.com> Date: Sat, 27 Aug 2016 09:09:11 +0800 From: Eli Cooper <elicooper@....com> To: Shmulik Ladkani <shmulik.ladkani@...il.com>, Tom Herbert <tom@...bertland.com> Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net> Subject: Re: [PATCH] ipv6: Don't unset flowi6_proto in ipxip6_tnl_xmit() Hi, On 2016/8/27 3:49, Shmulik Ladkani wrote: > However new users of 'ip6_tnl_xmit' (e.g. __gre6_xmit callers) may still > have their 'fl6->flowi6_proto' not armed. > > Maybe the right fix is assigning 'fl6->flowi6_proto = proto', either at > start of 'ip6_tnl_xmit' or just prior the ip6_route_output() call. The only other user of ip6_tnl_xmit() is ip6gre, and it has its fl6->flowi6_proto set in ip6gre_tnl_link_config() as in commit 252f3f5a1189 ("ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit path.") Assigning flowi6_proto at the start of ip6_tnl_xmit() was also my first idea, but I was unsure which fix would be better. Thanks, Eli
Powered by blists - more mailing lists