netdev - Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57C186FF.6090702@codeaurora.org>
Date:   Sat, 27 Aug 2016 07:26:39 -0500
From:   Timur Tabi <timur@...eaurora.org>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, sdharia@...eaurora.org,
        shankerd@...eaurora.org, vikrams@...eaurora.org,
        cov@...eaurora.org, gavidov@...eaurora.org, robh+dt@...nel.org,
        andrew@...n.ch, bjorn.andersson@...aro.org, mlangsdo@...hat.com,
        jcm@...hat.com, agross@...eaurora.org, f.fainelli@...il.com,
        LinoSanfilippo@....de
Subject: Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

David Miller wrote:
> From: Timur Tabi <timur@...eaurora.org>
> Date: Thu, 25 Aug 2016 16:39:03 -0500
>
>> +static const u8 duuid[] = {
>> +	0x77, 0x79, 0x60, 0xbf,
>> +	0x2d, 0xab,
>> +	0x9d, 0x4b,
>> +	0x94, 0xf0,
>> +	0xe1, 0x11, 0x98, 0x01, 0xa2, 0xba
>> +};
>
> This seems to be completely unused, please remove it.

Sorry, I missed that during my cleanup.  I'll remove it in v10.

I wonder why my compiler didn't complain about the unused static.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.