lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <59758948-d899-a32f-12af-a56b8c0da6c1@cogentembedded.com> Date: Sat, 27 Aug 2016 19:18:16 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Oleg Drokin <green@...uxhacker.ru> Cc: Stephen Hemminger <stephen@...workplumber.org>, "David S. Miller" <davem@...emloft.net>, bridge@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] bridge: Fix format string for %ul Hello. On 8/27/2016 6:58 PM, Oleg Drokin wrote: >>> %ul would print an unsigned value and a letter l, >>> likely it was %lu that was meant to print the long int, >>> but in reality the values printed there are just regular signed >> >> Signed? Then you need probably "%d" or "%i"… > > They are signed in the struct definition, but in reality they > designate time, so could not be negative, I imagine? That doesn't matter. If the type is signed, it should be printed as signed. Doesn't gcc complain about the format specifiers not matching the values passed? >>> ints, so just dropping the l altogether. >>> >>> Signed-off-by: Oleg Drokin <green@...uxhacker.ru> >> [...] MBR, Sergei
Powered by blists - more mailing lists