netdev - Re: [PATCH net-next v4 0/3] net: mpls: fragmentation and gso fixes for locally originated traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160829122949.GB25359@penelope.isobedori.kobe.vergenet.net>
Date:   Mon, 29 Aug 2016 14:29:51 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     David Miller <davem@...emloft.net>
Cc:     dsa@...ulusnetworks.com, netdev@...r.kernel.org,
        buytenh@...tstofly.org, ebiederm@...ssion.com,
        rshearma@...cade.com, tom@...bertland.com, tgraf@...g.ch,
        olivier.dugeon@...nge.com, alexander.duyck@...il.com,
        roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next v4 0/3] net: mpls: fragmentation and gso fixes
 for locally originated traffic

On Mon, Aug 29, 2016 at 02:07:30PM +0200, Simon Horman wrote:
> On Fri, Aug 26, 2016 at 11:41:37AM -0700, David Miller wrote:
> > From: David Ahern <dsa@...ulusnetworks.com>
> > Date: Wed, 24 Aug 2016 20:10:42 -0700
> > 
> > > This series fixes mtu and fragmentation for tunnels using lwtunnel
> > > output redirect, and fixes GSO for MPLS for locally originated traffic
> > > reported by Lennert Buytenhek.
> > > 
> > > A follow on series will address fragmentation and GSO for forwarded
> > > MPLS traffic. Hardware offload of GSO with MPLS also needs to be
> > > addressed.
> > > 
> > > Simon: Can you verify this works with OVS for single and multiple
> > >        labels?
> > 
> > Simon, I'm waiting on your testing before I apply this series.
> 
> Sorry for the delay. I will test it ASAP.

Sorry once again for the delay,

I have tested this series for both of the following:
* IPv4 in MPLS (just after the ethernet header)
* IPv4 in MPLS in GRE (TEB)

Things seem to work fine.

Tested-by: Simon Horman <simon.horman@...ronome.com>

Expanding a little on the above:

* I tested this using the test cases I have been working on for OvS here:
  http://www.spinics.net/lists/netdev/msg391755.html

  Those test make use of namespaces connected using veth and
  push/pop_mpls actions.

* As the above is quite new I also tested the patchset using my somewhat
  more clumsy local test environment which uses KVM, virtio net and
  push/pop_mpls actions.