netdev - [PATCH v3 5/5] net: asix: autoneg will set WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 09:32:19 -0400
From:   robert.foss@...labora.com
To:     freddy@...x.com.tw, Dean_Jenkins@...tor.com,
        Mark_Craske@...tor.com, davem@...emloft.net,
        robert.foss@...labora.com, ivecera@...hat.com,
        john.stultz@...aro.org, vpalatin@...omium.org,
        stephen@...workplumber.org, grundler@...omium.org,
        changchias@...il.com, allan@...x.com.tw, andrew@...n.ch,
        tremyfr@...il.com, colin.king@...onical.com,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, vpalatin@...gle.com
Cc:     Grant Grundler <grundler@...gle.com>
Subject: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

From: Robert Foss <robert.foss@...labora.com>

From: Grant Grundler <grundler@...omium.org>

The miii_nway_restart() causes a PHY link change activity and
ax88772_link_reset will be called. link_reset will set
AX_CMD_WRITE_MEDIUM_MODE register correctly.

The asix_write_medium_mode in reset() fills in a default value to the register
which may be different from the negotiation result. So do this first.

Ignore the ret value since it's ignored in XXX_link_reset() functions.

Signed-off-by: Grant Grundler <grundler@...gle.com>
Signed-off-by: Robert Foss <robert.foss@...labora.com>
Tested-by: Robert Foss <robert.foss@...labora.com>
---
 drivers/net/usb/asix_devices.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index dbcdda2..cce2495 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -928,12 +928,9 @@ static int ax88178_reset(struct usbnet *dev)
 	asix_mdio_write(dev->net, dev->mii.phy_id, MII_CTRL1000,
 			ADVERTISE_1000FULL);
 
+	asix_write_medium_mode(dev, AX88178_MEDIUM_DEFAULT, 0);
 	mii_nway_restart(&dev->mii);
 
-	ret = asix_write_medium_mode(dev, AX88178_MEDIUM_DEFAULT, 0);
-	if (ret < 0)
-		return ret;
-
 	/* Rewrite MAC address */
 	memcpy(data->mac_addr, dev->net->dev_addr, ETH_ALEN);
 	ret = asix_write_cmd(dev, AX_CMD_WRITE_NODE_ID, 0, 0, ETH_ALEN,
-- 
git-series 0.8.10