netdev - Re: [PATCH 4/5] net_sched: fix use of uninitialized ethertype variable in cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160829.003056.872235296198766893.davem@davemloft.net>
Date:   Mon, 29 Aug 2016 00:30:56 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        hadarh@...lanox.com, jiri@...lanox.com, netdev@...r.kernel.org
Subject: Re: [PATCH 4/5] net_sched: fix use of uninitialized ethertype
 variable in cls_flower

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 26 Aug 2016 17:25:45 +0200

> The addition of VLAN support caused a possible use of uninitialized
> data if we encounter a zero TCA_FLOWER_KEY_ETH_TYPE key, as pointed
> out by "gcc -Wmaybe-uninitialized":
> 
> net/sched/cls_flower.c: In function 'fl_change':
> net/sched/cls_flower.c:366:22: error: 'ethertype' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> This changes the code to only set the ethertype field if it
> was nonzero, as before the patch.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 9399ae9a6cb2 ("net_sched: flower: Add vlan support")

Applied.