netdev - Re: [patch iproute2 1/2] tc: Add support for the matchall traffic classifier.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160829184045.GA2012@nanopsycho.orion>
Date:   Mon, 29 Aug 2016 20:40:45 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, yotamg@...lanox.com, eladr@...lanox.com,
        idosch@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com
Subject: Re: [patch iproute2 1/2] tc: Add support for the matchall traffic
 classifier.

Mon, Aug 29, 2016 at 08:03:21PM CEST, stephen@...workplumber.org wrote:
>On Mon, 22 Aug 2016 13:56:25 +0200
>Jiri Pirko <jiri@...nulli.us> wrote:
>
>> From: Yotam Gigi <yotamg@...lanox.com>
>> 
>> The matchall classifier matches every packet and allows the user to apply
>> actions on it. In addition, it supports the skip_sw and skip_hw (as can
>> be found on u32 and flower filter) that direct the kernel to skip the
>> software/hardware processing of the actions.
>> 
>> This filter is very useful in usecases where every packet should be
>> matched. For example, packet mirroring (SPAN) can be setup very easily
>> using that filter.
>> 
>> Signed-off-by: Yotam Gigi <yotamg@...lanox.com>
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>
>I am not a checkpatch purist, but these two should be addressed.
>
>
>WARNING: unnecessary whitespace before a quoted newline
>#81: FILE: tc/f_matchall.c:29:
>+	fprintf(stderr, "Usage: ... matchall [skip_sw | skip_hw] \n");
>
>WARNING: braces {} are not necessary for single statement blocks
>#185: FILE: tc/f_matchall.c:133:
>+	if (tb[TCA_MATCHALL_ACT]) {
>+		tc_print_action(f, tb[TCA_MATCHALL_ACT]);
>+	}

will fix and send v2. Thanks.