netdev - Re: [PATCH] fix:gpio: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87vayj3h82.fsf@purkki.adurom.net>
Date:   Mon, 29 Aug 2016 15:14:05 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     ath9k-devel@....qualcomm.com, linux-wireless@...r.kernel.org,
        ath9k-devel@...ts.ath9k.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, arnd@...aro.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH] fix:gpio: mark symbols static where possible

Baoyou Xie <baoyou.xie@...aro.org> writes:

> We get 1 warning about global functions without a declaration
> in the ath9k gpio driver when building with W=1:
> drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype for 'ath_fill_led_pin' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/net/wireless/ath/ath9k/gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The commit title should be:

ath9k: mark ath_fill_led_pin() static

Check the wiki how to create titles:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name

-- 
Kalle Valo