netdev - Re: [PATCH v4] brcmfmac: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87twe244u6.fsf@kamboji.qca.qualcomm.com>
Date:   Tue, 30 Aug 2016 19:08:33 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        Arend Van Spriel <arend.vanspriel@...adcom.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
        "open list\:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
        <brcm80211-dev-list.pdl@...adcom.com>,
        Network Development <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, xie.baoyou@....com.cn
Subject: Re: [PATCH v4] brcmfmac: add missing header dependencies

Baoyou Xie <baoyou.xie@...aro.org> writes:

> On 29 August 2016 at 23:31, Rafał Miłecki <zajec5@...il.com> wrote:
>
>     On 29 August 2016 at 14:39, Baoyou Xie <baoyou.xie@...aro.org> wrote:
>     > We get 1 warning when build kernel with W=1:
>     > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6:
>     warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
>
>     building? I'm not native English, but I think so.
>    
>
>     > In fact, this function is declared in brcmfmac/debug.h, so this patch
>     > add missing header dependencies.
>
>     adds
>    
>
>     > Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
>     > Acked-by: Arnd Bergmann <arnd@...db.de>
>
>     Please don't resend patches just to add tags like that. This only
>     increases a noise and patchwork handles this just fine, see:
>     https://patchwork.kernel.org/patch/9303285/
>     https://patchwork.kernel.org/patch/9303285/mbox/
>
>
> Do I need to resend a patch that fixes two typos(build/add)? or you modify them
> on your way?

I can fix those when I commit the patch.

-- 
Kalle Valo