netdev - Re: [PATCH net-next v3 0/2] net: bridge: add per-port unknown multicast flood control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2016 08:59:18 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        bridge@...ts.linux-foundation.org, davem@...emloft.net
Subject: Re: [PATCH net-next v3 0/2] net: bridge: add per-port unknown
 multicast flood control

On Wed, 31 Aug 2016 15:36:50 +0200
Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:

> Hi,
> The first patch prepares the forwarding path by having the exact packet
> type passed down so we can later filter based on it and the per-port
> unknown mcast flood flag introduced in the second patch. It is similar to
> how the per-port unknown unicast flood flag works.
> Nice side-effects of patch 01 are the slight reduction of tests in the
> fast-path and a few minor checkpatch fixes.
> 
> v3: don't change br_auto_mask as that will change user-visible behaviour
> v2: make pkt_type an enum as per Stephen's comment
> 
> Thanks,
>  Nik
> 
> 
> Nikolay Aleksandrov (2):
>   net: bridge: change unicast boolean to exact pkt_type
>   net: bridge: add per-port multicast flood flag
> 
>  include/linux/if_bridge.h    |  1 +
>  include/uapi/linux/if_link.h |  1 +
>  net/bridge/br_device.c       |  8 ++++----
>  net/bridge/br_forward.c      |  7 +++++--
>  net/bridge/br_if.c           |  2 +-
>  net/bridge/br_input.c        | 40 +++++++++++++++++++++++++---------------
>  net/bridge/br_netlink.c      | 12 +++++++++---
>  net/bridge/br_private.h      |  7 ++++++-
>  net/bridge/br_sysfs_if.c     |  1 +
>  9 files changed, 53 insertions(+), 26 deletions(-)
> 

Looks good thanks, and most importantly shouldn't break existing users.

Acked-by: Stephen Hemminger <stephen@...workplumber.org>