netdev - Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57C74562.3050203@codeaurora.org>
Date:   Wed, 31 Aug 2016 16:00:18 -0500
From:   Timur Tabi <timur@...eaurora.org>
To:     Rob Herring <robh@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Sagar Dharia <sdharia@...eaurora.org>,
        Shanker Donthineni <shankerd@...eaurora.org>,
        Vikram Sethi <vikrams@...eaurora.org>,
        Christopher Covington <cov@...eaurora.org>,
        Gilad Avidov <gavidov@...eaurora.org>,
        Andrew Lunn <andrew@...n.ch>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mark Langsdorf <mlangsdo@...hat.com>,
        "jcm@...hat.com" <jcm@...hat.com>,
        Andy Gross <agross@...eaurora.org>,
        David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Lino Sanfilippo <LinoSanfilippo@....de>
Subject: Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

Rob Herring wrote:
>> It's not a generic phy.  It's a funky "internal phy" that differs among
>> >SOCs.  I call it the internal phy, but I could use another name. Internally,
>> >some people call it the "sgmii phy", but I don't think that's accurate.

> Funky internal PHYs are precisely the types of PHYs this binding is
> for. It is generic in that the type is not defined. It can be USB,
> HDMI, DSI, LVDS, etc.

I don't understand what you're getting at.  There are two IP blocks that 
have a private interconnect.  One is the MAC, and the other is an 
internal PHY, but the driver programs them as one device.

If you want me to make some kind of change, you're going to have to be 
more specific.

>> >That's what I thought to, but without it, of_phy_find_device() won't work.
>> >I need a pointer to the phy node, and I use of_parse_phandle() to get it:
>> >
>> >         struct device_node *phy_np;
>> >
>> >         ret = of_mdiobus_register(mii_bus, np);
>> >         if (ret) {
>> >                 dev_err(&pdev->dev, "could not register mdio bus\n");
>> >                 return ret;
>> >         }
>> >
>> >         phy_np = of_parse_phandle(np, "phy-handle", 0);

> You can just as easily find the child node called ethernet-phy.

As Andrew pointed out, using phy-handle allows me to place the phy node 
anywhere.

I've already made changes to this design, and every change has raised 
objections.  I don't see anything wrong with phy-handle.  A lot of 
drivers use it.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.