netdev - Re: [PATCH] irda: Fix likely typo in output format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <857C547F-D381-44F4-A5E5-C8B390B931F3@linuxhacker.ru>
Date:   Wed, 31 Aug 2016 17:36:44 -0400
From:   Oleg Drokin <green@...uxhacker.ru>
To:     David Miller <davem@...emloft.net>
Cc:     samuel@...tiz.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irda: Fix likely typo in output format string


On Aug 31, 2016, at 5:31 PM, David Miller wrote:

> From: Oleg Drokin <green@...uxhacker.ru>
> Date: Fri, 26 Aug 2016 23:14:06 -0400
> 
>> %ul would print an unsigned with a letter l at the end which does
>> not seem to be desired here, on the other hand the value being printed
>> is u32 so just drop the l instead of converting to %lu
>> 
>> Signed-off-by: Oleg Drokin <green@...uxhacker.ru>
> 
> %u is for unsigned values, and these are "s32" thus signed.

Hm, you are right.
I could swear I saw them as unsigned when I looked at it.

Anyway can they really be negative? they are seconds and usec,
should I change them to u32 too?