netdev - Re: [PATCH] iproute: disallow ip rule del without parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160901090540.707a6c87@xeon-e3>
Date:   Thu, 1 Sep 2016 09:05:40 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     "Andrey Jr. Melnikov" <temnota.am@...il.com>,
        Stephen Hemminger <shemminger@...l.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] iproute: disallow ip rule del without parameters

On Tue, 30 Aug 2016 13:51:56 +0200
Michal Kubecek <mkubecek@...e.cz> wrote:

> On Mon, Aug 29, 2016 at 10:53:25AM -0700, Stephen Hemminger wrote:
> > On Wed, 24 Aug 2016 23:43:00 +0300
> > "Andrey Jr. Melnikov" <temnota.am@...il.com> wrote:
> >   
> > > Disallow run `ip rule del` without any parameter to avoid delete any first
> > > rule from table.  
> ...
> > Actually ip rule delete without arguments deletes all rules.
> > Which could be a bug or feature depending on the user.
> > I can imagine somebody is doing something like deleting all rules
> > and putting in new ones for PBR.  
> 
> We have "ip rule flush" for that, don't we?
> 
> Michal Kubecek

I went ahead and applied this, seemed better to give error than deleting
all rules.