netdev - Re: [PATCH iproute2] ip: route: fix multicast route dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160901090719.7c763916@xeon-e3>
Date:   Thu, 1 Sep 2016 09:07:19 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, sashok@...ulusnetworks.com,
        roopa@...ulusnetworks.com
Subject: Re: [PATCH iproute2] ip: route: fix multicast route dumps

On Sat, 20 Aug 2016 14:53:10 +0200
Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:

> If we have multicast routes and do ip route show table all we'll get the
> following output:
>  ...
>  multicast ???/32 from ???/32  table default  proto static  iif eth0
> The "???" are because the rtm_family is set to RTNL_FAMILY_IPMR instead
> (or RTNL_FAMILY_IP6MR for ipv6). Add a simple workaround that returns the
> real family based on the rtm_type (always RTN_MULTICAST for ipmr routes)
> and the rtm_family. Similar workaround is already used in ipmroute, and
> we can use this helper there as well.
> 
> After the patch the output is:
> multicast 239.10.10.10/32 from 0.0.0.0/32  table default  proto static  iif eth0
> 
> Also fix a minor whitespace error and switch to tabs.
> 
> Reported-by: Satish Ashok <sashok@...ulusnetworks.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

This makes sense, applied it.
Hope no one was actually depending on the ??? output.