netdev - Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18052c6d-2cb1-0927-7d33-92d4bd397aa4@collabora.com>
Date:   Thu, 1 Sep 2016 12:47:27 -0400
From:   Robert Foss <robert.foss@...labora.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     freddy@...x.com.tw, Dean_Jenkins@...tor.com,
        Mark_Craske@...tor.com, davem@...emloft.net, ivecera@...hat.com,
        john.stultz@...aro.org, vpalatin@...omium.org,
        stephen@...workplumber.org, grundler@...omium.org,
        changchias@...il.com, allan@...x.com.tw, andrew@...n.ch,
        tremyfr@...il.com, colin.king@...onical.com,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, vpalatin@...gle.com,
        Grant Grundler <grundler@...gle.com>
Subject: Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg



On 2016-09-01 12:43 PM, Eric Dumazet wrote:
> On Mon, 2016-08-29 at 09:32 -0400, robert.foss@...labora.com wrote:
>> From: Robert Foss <robert.foss@...labora.com>
>>
>> From: Grant Grundler <grundler@...omium.org>
>>
>> The miii_nway_restart() causes a PHY link change activity and
>> ax88772_link_reset will be called. link_reset will set
>> AX_CMD_WRITE_MEDIUM_MODE register correctly.
>>
>> The asix_write_medium_mode in reset() fills in a default value to the register
>> which may be different from the negotiation result. So do this first.
>>
>> Ignore the ret value since it's ignored in XXX_link_reset() functions.
>>
>> Signed-off-by: Grant Grundler <grundler@...gle.com>
>> Signed-off-by: Robert Foss <robert.foss@...labora.com>
>> Tested-by: Robert Foss <robert.foss@...labora.com>
>> ---
>
> This is _really_ confusing Robert.
>
> Why having two 'From:' clauses ?
>
> Who wrote the patch in the first place ? You or Grant ?

I'm not quite sure how the first From line was added, it
should not have been.
Grant Grundler is most definitely the author.

Would you like me to resubmit in v++ and make sure that it has been 
corrected?

>
>
>
> End result is :
>
> commit 535baf8588d04b177cb33700f81499f2b5203c2d
> Author: Robert Foss <robert.foss@...labora.com>
> Date:   Mon Aug 29 09:32:19 2016 -0400
>
>     net: asix: autoneg will set WRITE_MEDIUM reg
>
>     From: Grant Grundler <grundler@...omium.org>
>
>     The miii_nway_restart() causes a PHY link change activity and
>     ax88772_link_reset will be called. link_reset will set
>     AX_CMD_WRITE_MEDIUM_MODE register correctly.
>
>     The asix_write_medium_mode in reset() fills in a default value to the register
>     which may be different from the negotiation result. So do this first.
>
>     Ignore the ret value since it's ignored in XXX_link_reset() functions.
>
>     Signed-off-by: Grant Grundler <grundler@...gle.com>
>     Signed-off-by: Robert Foss <robert.foss@...labora.com>
>     Tested-by: Robert Foss <robert.foss@...labora.com>
>     Signed-off-by: David S. Miller <davem@...emloft.net>
>
>
>
> I guess Grant wrote the patch, but attribution is wrong.
>
>