netdev - Re: [PATCH v3 0/4] net: smsc911x: Move phy and interrupt config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2c1378f-d172-a309-e776-918c3e6d571c@cogentembedded.com>
Date:   Fri, 2 Sep 2016 00:07:54 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org
Cc:     steve.glendinning@...well.net, andrew@...n.ch, will.deacon@....com
Subject: Re: [PATCH v3 0/4] net: smsc911x: Move phy and interrupt config

On 09/01/2016 11:15 PM, Jeremy Linton wrote:

> v2-v3: Move error handing into separate patch, replace a couple cases
>  of fixed errors with the errors being returned from the failing functions.
>  Hoist irq handler.

    This is normally at end of the blurb, also you're supposed to keep all 
version history here.

> The smsc911x driver is doing a number of things in its probe routine that
> should be delayed until the interface is started. Because of this, the module
> cannot be unloaded, the phy states are incorrect/stale if the interface isn't
> running, open's unnecessarily fail causing network configuration problems, and
> the /proc/irq nodes are incorrectly named.

    /proc/interrupts maybe?

> Clean up a number of these problems by moving the mdio and interrupt
> configuration into the smsc911x_open routine.
>
> Jeremy Linton (4):
>   net: smsc911x: Remove multiple exit points from smsc911x_open
>   net: smsc911x: Fix register_netdev, phy startup, driver unload
>     ordering
>   net: smsc911x: Move interrupt handler before open
>   net: smsc911x: Move interrupt allocation to open/stop

    Thank you for your insistence on getting this driver straight! I'll try to 
review/test your patches.

MBR, Sergei