netdev - Re: [PATCH 2/4] net: smsc911x: Fix register_netdev, phy startup, driver unload ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160901204923.GB16864@lunn.ch>
Date:   Thu, 1 Sep 2016 22:49:23 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jeremy Linton <jeremy.linton@....com>
Cc:     netdev@...r.kernel.org, steve.glendinning@...well.net,
        sergei.shtylyov@...entembedded.com, will.deacon@....com
Subject: Re: [PATCH 2/4] net: smsc911x: Fix register_netdev, phy startup,
 driver unload ordering

> @@ -1604,7 +1599,7 @@ static int smsc911x_open(struct net_device *dev)
>  		netdev_warn(dev, "ISR failed signaling test (IRQ %d)\n",
>  			    dev->irq);
>  		retval = -ENODEV;
> -		goto out;
> +		goto mii_free_out;

A nit pick, but it is not really freeing anything.
Maybe you can think of a better name?

Otherwise

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew