netdev - Re: [PATCH net-next 0/4] xps_flows: XPS flow steering when there is no socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dad8e78-25f4-4fd0-6cab-8004dac45662@gmail.com>
Date:   Thu, 1 Sep 2016 12:46:52 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Tom Herbert <tom@...bertland.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Kernel Team <kernel-team@...com>,
        Rick Jones <rick.jones2@....com>
Subject: Re: [PATCH net-next 0/4] xps_flows: XPS flow steering when there is
 no socket

On 09/01/2016 12:32 PM, Tom Herbert wrote:
> On Thu, Sep 1, 2016 at 12:25 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
>> On 08/31/2016 05:10 PM, Tom Herbert wrote:
>>> This patch set introduces transmit flow steering for socketless packets.
>>> The idea is that we record the transmit queues in a flow table that is
>>> indexed by skbuff hash.  The flow table entries have two values: the
>>> queue_index and the head cnt of packets from the TX queue. We only allow
>>> a queue to change for a flow if the tail cnt in the TX queue advances
>>> beyond the recorded head cnt. That is the condition that should indicate
>>> that all outstanding packets for the flow have completed transmission so
>>> the queue can change.
>>>
>>> Tracking the inflight queue is performed as part of DQL. Two fields are
>>> added to the dql structure: num_enqueue_ops and num_completed_ops.
>>> num_enqueue_ops incremented in dql_queued and num_completed_ops is
>>> incremented in dql_completed by the number of operations completed (an
>>> new argument to the function).
>>>
>>> This patch set creates /sys/class/net/eth*/xps_dev_flow_table_cnt
>>> which number of entries in the XPS flow table.
>>
>> If you respin, do you mind updating the sysfs documentation at
>> Documentation/ABI/testing/sysfs-class-net-queues with the new entries
>> you are adding? Thanks!
> 
> There are no per-queue sysfs entries being added.

OK I pasted the wrong file, how about this one:
Documentation/ABI/testing/sysfs-class-net

the point being, you add a new attribute, you document it.
-- 
Florian