netdev - Re: [PATCH] net: xgene: fix backward compatibility fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160901.100108.1348875318377995073.davem@davemloft.net>
Date:   Thu, 01 Sep 2016 10:01:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     isubramanian@....com, kchudgar@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: xgene: fix backward compatibility fix

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 29 Aug 2016 14:37:14 +0200

> A bugfix for backward compatibility handling introduced undefined
> behavior for the case that of_parse_phandle() does not return
> a valid entry, as "gcc -Wmaybe-unused" reports:
> 
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 'xgene_enet_phy_connect':
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:776:6: error: 'phy_dev' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 'xgene_enet_mdio_config':
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:776:6: error: 'phy_dev' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> We can work around this by removing the check for zero "np", as
> of_phy_connect() will correctly handle a NULL argument so we fall
> back into the normal error handling case.
> 
> Note that I had previously fixed another bug that resulted in the
> exact same warning, but this is a different problem that was
> introduced after my original fix.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 03377e381bf4 ("drivers: net: xgene: Fix backward compatibility")

Applied.