netdev - Re: [PATCH net] net: bridge: don't increment tx_dropped in br_do_proxy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160901.163542.1374337978886389909.davem@davemloft.net>
Date:   Thu, 01 Sep 2016 16:35:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     nikolay@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, kyeyoonp@...eaurora.org,
        roopa@...ulusnetworks.com, stephen@...workplumber.org,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net] net: bridge: don't increment tx_dropped in
 br_do_proxy_arp

From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Date: Tue, 30 Aug 2016 17:44:29 +0200

> pskb_may_pull may fail due to various reasons (e.g. alloc failure), but the
> skb isn't changed/dropped and processing continues so we shouldn't
> increment tx_dropped.
> 
> CC: Kyeyoon Park <kyeyoonp@...eaurora.org>
> CC: Roopa Prabhu <roopa@...ulusnetworks.com>
> CC: Stephen Hemminger <stephen@...workplumber.org>
> CC: bridge@...ts.linux-foundation.org
> Fixes: 958501163ddd ("bridge: Add support for IEEE 802.11 Proxy ARP")
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Applied, thanks.