netdev - Re: [PATCH net-next] switchdev: Fix return value of switchdev_port_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57C97A8A.2090203@cumulusnetworks.com>
Date:   Fri, 02 Sep 2016 06:11:38 -0700
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Rami Rosen <rami.rosen@...el.com>
CC:     davem@...emloft.net, netdev@...r.kernel.org,
        eric.dumazet@...il.com, wkok@...ulusnetworks.com
Subject: Re: [PATCH net-next] switchdev: Fix return value of switchdev_port_fdb_dump().

On 9/2/16, 4:11 AM, Rami Rosen wrote:
> This patch fixes the retun value of switchdev_port_fdb_dump() when
> CONFIG_NET_SWITCHDEV is not set. This avoids getting "warning: return makes
> integer from pointer without a cast [-Wint-conversion]" when building
> when CONFIG_NET_SWITCHDEV is not set under several compiler versions.
> This warning is due to commit d297653dd6f07afbe7e6c702a4bcd7615680002e
> ("rtnetlink: fdb dump: optimize by saving last interface markers").
>
> Signed-off-by: Rami Rosen <rami.rosen@...el.com>
> ---

Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Thanks Rami.
>  include/net/switchdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index 6279f2f..729fe15 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -344,7 +344,7 @@ static inline int switchdev_port_fdb_dump(struct sk_buff *skb,
>  					  struct net_device *filter_dev,
>  					  int *idx)
>  {
> -       return idx;
> +       return *idx;
>  }
>  
>  static inline bool switchdev_port_same_parent_id(struct net_device *a,