netdev - Re: [PATCH net] bonding: Fix bonding crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472823200.5439.15.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Fri, 02 Sep 2016 06:33:20 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Mahesh Bandewar <mahesh@...dewar.net>,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Andy Gospodarek <gospo@...ulusnetworks.com>,
        Veaceslav Falico <vfalico@...il.com>,
        David Miller <davem@...emloft.net>,
        Mahesh Bandewar <maheshb@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] bonding: Fix bonding crash

On Fri, 2016-09-02 at 09:52 +0200, Jiri Pirko wrote:

> 
> No, please, don't make bonding a spacial citizen introducing this.
> Please handle the issue inside the bonding code, like we do for the rest
> of master devices (and how it was once done for bonding). Thanks.

I do not feel this netdev_is_rx_handler_busy() use is special to
bonding.

It makes sense to use it early, to avoid complex rollback, once various
events have been sent all over.

bond_enslave() is 447 lines long already.

You perfectly know how hard it is to 'handle the issue inside the
bonding code' as you chose to not fix bonding and write team instead.

So Mahesh patch makes perfect sense to me. It exactly fixes a stupid
bond_enslave() behavior, trying to set rx_handler way too late.

By doing sanity checks before any action, we simply do not have to add
complex rollback.

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks.