netdev - Re: [PATCH net-next] rtnetlink: fdb dump: optimize by saving last interface markers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472792070.5439.11.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Thu, 01 Sep 2016 21:54:30 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     davem@...emloft.net, nikolay@...ulusnetworks.com,
        wkok@...ulusnetworks.com, stephen@...workplumber.org,
        jhs@...atatu.com, makita.toshiaki@....ntt.co.jp, jiri@...nulli.us,
        idosch@...lanox.com, netdev@...r.kernel.org, minoura@...inux.co.jp,
        Dept-GELinuxNICDev@...gic.com
Subject: Re: [PATCH net-next] rtnetlink: fdb dump: optimize by saving last
 interface markers

On Tue, 2016-08-30 at 21:56 -0700, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>

> @@ -342,7 +342,7 @@ static inline int switchdev_port_fdb_dump(struct sk_buff *skb,
>  					  struct netlink_callback *cb,
>  					  struct net_device *dev,
>  					  struct net_device *filter_dev,
> -					  int idx)
> +					  int *idx)
>  {
>         return idx;
>  }


Compiler is not happy with this change.

$ grep CONFIG_NET_SWITCHDEV .config
# CONFIG_NET_SWITCHDEV is not set

...

./include/net/switchdev.h: In function 'switchdev_port_fdb_dump':
./include/net/switchdev.h:347:8: warning: return makes integer from pointer without a cast [enabled by default]

Thanks.