netdev - Re: [PATCH] ipv6: Don't unset flowi6_proto in ipxip6_tnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160901.234147.2300105032472747034.davem@davemloft.net>
Date:   Thu, 01 Sep 2016 23:41:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     elicooper@....com
Cc:     netdev@...r.kernel.org, tom@...bertland.com
Subject: Re: [PATCH] ipv6: Don't unset flowi6_proto in ipxip6_tnl_xmit()

From: Eli Cooper <elicooper@....com>
Date: Thu, 1 Sep 2016 09:18:04 +0800

> Hello,
> 
> On 2016/9/1 4:56, David Miller wrote:
>> From: Eli Cooper <elicooper@....com>
>> Date: Fri, 26 Aug 2016 23:52:29 +0800
>>
>>> @@ -1174,6 +1174,7 @@ ip4ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev)
>>>  		encap_limit = t->parms.encap_limit;
>>>  
>>>  	memcpy(&fl6, &t->fl.u.ip6, sizeof(fl6));
>>> +	fl6.flowi6_proto = IPPROTO_IPIP;
>> Let's just simply have t->fl have the proto setup properly, just like
>> in GRE.
>>
>> Assigning it explicitly every packet transmit doesn't make much sense.
> 
> I doubt that. Unlike GRE, where the proto must be IPPROTO_GRE, the proto
> here can be either IPPROTO_IPV6 or IPPROTO_IPIP for a single tunnel, and
> t->fl is shared by them. Thus it has to be assigned for every packet.

You're right.  Patch applied, thanks for explaining.