netdev - Re: [PATCH 2/2 nf-next] netfilter: seqadj: print the warning log when fail to add seqadj extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160902065445.GB8883@breakpoint.cc>
Date:   Fri, 2 Sep 2016 08:54:45 +0200
From:   Florian Westphal <fw@...len.de>
To:     fgao@...ai8.com
Cc:     pablo@...filter.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        gfree.wind@...il.com
Subject: Re: [PATCH 2/2 nf-next] netfilter: seqadj: print the warning log
 when fail to add seqadj extension

fgao@...ai8.com <fgao@...ai8.com> wrote:
> From: Gao Feng <fgao@...ai8.com>
> 
> Print the warning log when fail to add seqadj extension like
> nf_ct_acct_ext_add does. It could be helpful to find the problem.

Failure to add ext area means that we're pretty much completely out
of memory.  There is nothing the user could do, so pr_warn (or any other
log level ...) is not really helpful.

Besides, memory subsystem will already print diagnostic information in
that case.