lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <wrfjpool2mgz.fsf@redhat.com> Date: Sat, 03 Sep 2016 08:31:56 -0400 From: Jes Sorensen <Jes.Sorensen@...hat.com> To: Kalle Valo <kvalo@...eaurora.org> Cc: Baoyou Xie <baoyou.xie@...aro.org>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, arnd@...aro.org, xie.baoyou@....com.cn Subject: Re: fix:rtl8xxxu_core: mark symbols static where possible Kalle Valo <kvalo@...eaurora.org> writes: > Baoyou Xie <baoyou.xie@...aro.org> wrote: >> We get 1 warning about global functions without a declaration >> in the rtl8xxxu rtl8xxxu_core.c when building with W=1: >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: >> warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' >> [-Wmissing-prototypes] >> >> In fact, this function is only used in the file in which it is declared >> and don't need a declaration, but can be made static. >> so this patch marks it 'static'. >> >> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org> > > The title should be "rtl8xxxu: ". See: > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name > > Also I assume Jes will take this. Yes to both accounts! Thanks, Jes
Powered by blists - more mailing lists