lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4e586d21-51cf-768c-4aee-9b0a147f1183@canonical.com> Date: Sat, 3 Sep 2016 17:33:40 +0100 From: Colin Ian King <colin.king@...onical.com> To: "Valo, Kalle" <kvalo@....qualcomm.com> Cc: "ath10k@...ts.infradead.org" <ath10k@...ts.infradead.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] ath10k: fix memory leak on caldata on error exit path On 02/09/16 16:45, Valo, Kalle wrote: > Colin King <colin.king@...onical.com> writes: > >> From: Colin Ian King <colin.king@...onical.com> >> >> caldata is not being free'd on the error exit path, causing >> a memory leak. kfree it to fix the leak. >> >> Signed-off-by: Colin Ian King <colin.king@...onical.com> >> --- >> drivers/net/wireless/ath/ath10k/pci.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c >> index 9a22c47..886337c 100644 >> --- a/drivers/net/wireless/ath/ath10k/pci.c >> +++ b/drivers/net/wireless/ath/ath10k/pci.c >> @@ -2725,6 +2725,7 @@ static int ath10k_pci_hif_fetch_cal_eeprom(struct ath10k *ar, void **data, >> return 0; >> >> err_free: >> + kfree(caldata); >> kfree(data); >> >> return -EINVAL; > > I don't think we should free data at all: > > static int ath10k_download_cal_eeprom(struct ath10k *ar) > { > size_t data_len; > void *data = NULL; > int ret; > > ret = ath10k_hif_fetch_cal_eeprom(ar, &data, &data_len); > > Instead we should free only caldata, right? > Yep, good catch, I'll send V2 later. Colin
Powered by blists - more mailing lists