netdev - Re: [PATCH] vxlan: Update tx_errors statistics if vxlan_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160904161233.063d0009@griffin>
Date:   Sun, 4 Sep 2016 16:12:33 +0200
From:   Jiri Benc <jbenc@...hat.com>
To:     Haishuang Yan <yanhaishuang@...s.chinamobile.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb
 return err.

On Sun,  4 Sep 2016 18:52:51 +0800, Haishuang Yan wrote:
> If vxlan_build_skb return err < 0, tx_errors should be also increased.
> 
> Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
> ---
>  drivers/net/vxlan.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index f605a36..2c72dcd 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -2103,6 +2103,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev,
>  				      vni, md, flags, udp_sum);
>  		if (err < 0) {
>  			dst_release(ndst);
> +			dev->stats.tx_errors++;
>  			return;
>  		}
>  		udp_tunnel6_xmit_skb(ndst, sk, skb, dev,

Acked-by: Jiri Benc <jbenc@...hat.com>

The error path in vxlan_xmit_one deserves complete rework, though.

 Jiri