netdev - Re: [PATCH] qed: Remove OOM messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1473024140.5018.61.camel@perches.com>
Date:   Sun, 04 Sep 2016 14:22:20 -0700
From:   Joe Perches <joe@...ches.com>
To:     David Miller <davem@...emloft.net>
Cc:     Yuval.Mintz@...gic.com, Ariel.Elior@...gic.com,
        everest-linux-l2@...gic.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qed: Remove OOM messages

On Sun, 2016-09-04 at 13:28 -0700, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Fri,  2 Sep 2016 10:48:47 -0700
> 
> > These messages are unnecessary as OOM allocation failures already do
> > a dump_stack() giving more or less the same information.
> > 
> > $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64)
> >    text          data     bss     dec     hex filename
> >  126849         27968   32800  187617   2dce1 drivers/net/ethernet/qlogic/qed/built-in.o.new
> >  131506         27968   32800  192274   2ef12 drivers/net/ethernet/qlogic/qed/built-in.o.old
> > 
> > Miscellanea:
> > 
> > o Change allocs to the generally preferred forms where possible.
> > 
> > Signed-off-by: Joe Perches <joe@...ches.com>
> 
> Joe can you respin this against net-next?
> 
> It applies against 'net' but this isn't really a critical bug fix and
> it'll also create conflicts against net-next.

No worries, I'll spin it back after the qed -net changes
are pushed back into net-next.

Oh, they are now.  Give me a minute.