netdev - Re: A potential bug in drivers/net/ethernet/synopsys/dwc_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e72ce0af-c35d-bbf9-e30f-f40f3b9053f0@axis.com>
Date:   Mon, 5 Sep 2016 13:45:28 +0200
From:   Lars Persson <lars.persson@...s.com>
To:     Pavel Andrianov <andrianov@...ras.ru>,
        Lars Persson <larper@...s.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Vaishali Thakkar <vaishali.thakkar@...cle.com>,
        <ldv-project@...uxtesting.org>
Subject: Re: A potential bug in drivers/net/ethernet/synopsys/dwc_eth_qos.ko

Hi Pavel,

Thanks for the notification. I agree that we should register the device 
after all initialization has completed. A patch will be sent shortly.

BR,
  Lars


On 09/05/2016 10:26 AM, Pavel Andrianov wrote:
> Hi!
>
> There is a potential bug in
> drivers/net/ethernet/synopsys/dwc_eth_qos.ko. In dwceqos_probe there is
> a registration of net device (line 2879). After that initialization of
> common resources is continued (lines 2918, 2924, 2941), but at the
> moment handlers from net device may be already executed.
>
> Should the registration of net device be at the end of dwceqos_probe?
>