netdev - Re: [PATCH net-next 2/3] smsc95xx: Add register define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160906.132738.1194681585026078241.davem@davemloft.net>
Date:   Tue, 06 Sep 2016 13:27:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     Woojung.Huh@...rochip.com, steve.glendinning@...well.net,
        netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next 2/3] smsc95xx: Add register define

From: Joe Perches <joe@...ches.com>
Date: Fri, 02 Sep 2016 13:40:01 -0700

> On Fri, 2016-09-02 at 20:34 +0000, Woojung.Huh@...rochip.com wrote:
>> From: Woojung Huh <woojung.huh@...rochip.com>
>> 
>> Add STRAP_STATUS defines.
> []
>> diff --git a/drivers/net/usb/smsc95xx.h b/drivers/net/usb/smsc95xx.h
> []
>> @@ -144,6 +144,14 @@
>>  
>>  #define BURST_CAP			(0x38)
>>  
>> +#define	STRAP_STATUS			(0x3C)
>> +#define	STRAP_STATUS_PWR_SEL_		(0x00000020)
>> +#define	STRAP_STATUS_AMDIX_EN_		(0x00000010)
>> +#define	STRAP_STATUS_PORT_SWAP_		(0x00000008)
>> +#define	STRAP_STATUS_EEP_SIZE_		(0x00000004)
>> +#define	STRAP_STATUS_RMT_WKP_		(0x00000002)
>> +#define	STRAP_STATUS_EEP_DISABLE_	(0x00000001)
> 
> Using BIT would be more common.
> 
> Ending the #defines with an underscore is just odd
> and unappealing.

But that's what the rest of this file is doing already.

If we want to change this, it's a separate follow-up change.