netdev - Re: [PATCH v3] net: macb: initialize checksum when using checksum offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160906.134359.334009778514208272.davem@davemloft.net>
Date:   Tue, 06 Sep 2016 13:43:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     helmut.buchsbaum@...il.com
Cc:     nicolas.ferre@...el.com, tom@...bertland.com,
        michal.simek@...inx.com, netdev@...r.kernel.org,
        cyrille.pitchen@...el.com
Subject: Re: [PATCH v3] net: macb: initialize checksum when using checksum
 offloading

From: Helmut Buchsbaum <helmut.buchsbaum@...il.com>
Date: Sun,  4 Sep 2016 18:09:47 +0200

> I'm still struggling to get this fix right..
> 
> Changes since v2:
>  - do not blindly modify SKB contents according to Dave's legitimate
>    objection
> 
> Changes since v1:
>  - dropped disabling HW checksum offload for Zynq
>  - initialize checksum similar to net/ethernet/freescale/fec_main.c
> 
> -- >8 --
> MACB/GEM needs the checksum field initialized to 0 to get correct
> results on transmit in all cases, e.g. on Zynq, UDP packets with
> payload <= 2 otherwise contain a wrong checksums.
> 
> Signed-off-by: Helmut Buchsbaum <helmut.buchsbaum@...il.com>

Applied.