netdev - Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160906.155757.924163804989771884.davem@davemloft.net>
Date:   Tue, 06 Sep 2016 15:57:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hejianet@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        linux-kernel@...r.kernel.org, kuznet@....inr.ac.ru,
        jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
        vyasevich@...il.com, nhorman@...driver.com,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au
Subject: Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in
 {snmp,netstat}_seq_show

From: Jia He <hejianet@...il.com>
Date: Tue,  6 Sep 2016 10:30:04 +0800

> +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b))

Please do not define private min/max macros, use the existing max_t()
or similar as needed.