netdev - Re: [PATCH] lan78xx: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160906.155949.480171381998479160.davem@davemloft.net>
Date:   Tue, 06 Sep 2016 15:59:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baoyou.xie@...aro.org
Cc:     woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, arnd@...db.de, xie.baoyou@....com.cn
Subject: Re: [PATCH] lan78xx: mark symbols static where possible

From: Baoyou Xie <baoyou.xie@...aro.org>
Date: Tue,  6 Sep 2016 16:19:02 +0800

> We get a few warnings when building kernel with W=1:
> drivers/net/usb/lan78xx.c:1182:6: warning: no previous prototype for 'lan78xx_defer_kevent' [-Wmissing-prototypes]
> drivers/net/usb/lan78xx.c:1409:5: warning: no previous prototype for 'lan78xx_nway_reset' [-Wmissing-prototypes]
> drivers/net/usb/lan78xx.c:2000:5: warning: no previous prototype for 'lan78xx_set_mac_addr' [-Wmissing-prototypes]
> ....
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Applied.