netdev - Re: [PATCH v4 2/6] cgroup: add support for eBPF programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKoUAr=M6Mmqmrz=uRh6SEUXMki4m0yR+cGNZJUNe3pGk6NhNw@mail.gmail.com>
Date:   Wed, 7 Sep 2016 07:58:19 +0300
From:   Rami Rosen <roszenrami@...il.com>
To:     Daniel Mack <daniel@...que.org>
Cc:     htejun@...com, daniel@...earbox.net, ast@...com,
        David Miller <davem@...emloft.net>, kafai@...com, fw@...len.de,
        pablo@...filter.org, harald@...hat.com,
        Netdev <netdev@...r.kernel.org>,
        Sargun Dhillon <sargun@...gun.me>, cgroups@...r.kernel.org
Subject: Re: [PATCH v4 2/6] cgroup: add support for eBPF programs

Hi,


+ * __cgroup_bpf_update() - Update the pinned program of a cgroup, and
+ *                         propagate the change to descendants
+ * @cgrp: The cgroup which descendants to traverse

Missing here is @parent

+ * @prog: A new program to pin
+ * @type: Type of pinning operation (ingress/egress)

...

> +void __cgroup_bpf_update(struct cgroup *cgrp,
> +                        struct cgroup *parent,
> +                        struct bpf_prog *prog,
> +                        enum bpf_attach_type type)
> +{

Regards,
Rami Rosen