netdev - Re: [PATCH 3/3 v2] net: smsc911x: add wake-up event interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2016 15:51:05 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jeremy Linton <jeremy.linton@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Steve Glendinning <steve.glendinning@...c.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Kamlakant Patel <kamlakant.patel@...adcom.com>,
        Pavel Fedin <p.fedin@...sung.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Tony Lindgren <tony@...mide.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH 3/3 v2] net: smsc911x: add wake-up event interrupt support

On Wed, Aug 31, 2016 at 5:27 PM, Jeremy Linton <jeremy.linton@....com> wrote:

> The cleanup code in drv_remove seems to be missing, am I missing something?

No you're right it's just my bad coding. Fixing it and thanks for noticing.

> Also, do you want the wake-up to be active if the interface is downed?

Hm! Good point.

It seems most other drivers call
device_set_wakeup_enable() on the device inside a
foo_set_wol() (wake-on-LAN) from the
.set_wol() callback in struct ethtool_ops.

This is in response to the ethtool calls from userspace.

So we need to implement this too.

I don't know whether that has anything to do with whether
the interface is up or not, it seems orthogonal actually.

I will hold this patch back until I can investigate and test
and just resend patches 1+2 right now. (Bindings should
still be OK to merge I guess, and I think the RESET patch
is sorted out.)

Yours,
Linus Walleij