netdev - Re: [PATCH bug-fix] iproute: fix documentation for ip rule scan order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160908095955.GA10034@unicorn.suse.cz>
Date:   Thu, 8 Sep 2016 11:59:55 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Iskren Chernev <iskren@....im>, netdev@...r.kernel.org
Subject: Re: [PATCH bug-fix] iproute: fix documentation for ip rule scan order

On Thu, Sep 01, 2016 at 09:04:54AM -0700, Stephen Hemminger wrote:
> On Tue, 30 Aug 2016 17:32:52 -0700
> Iskren Chernev <iskren@....im> wrote:
> 
> > From 416f45b62f33017d19a9b14e7b0179807c993cbe Mon Sep 17 00:00:00 2001
> > From: Iskren Chernev <iskren@....im>
> > Date: Tue, 30 Aug 2016 17:08:54 -0700
> > Subject: [PATCH bug-fix] iproute: fix documentation for ip rule scan order
> > 
> > ---
> >  man/man8/ip-rule.8 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8
> > index 1774ae3..3508d80 100644
> > --- a/man/man8/ip-rule.8
> > +++ b/man/man8/ip-rule.8
> > @@ -93,7 +93,7 @@ Each policy routing rule consists of a
> >  .B selector
> >  and an
> >  .B action predicate.
> > -The RPDB is scanned in order of decreasing priority. The selector
> > +The RPDB is scanned in order of increasing priority. The selector
> >  of each rule is applied to {source address, destination address,
> > incoming
> >  interface, tos, fwmark} and, if the selector matches the packet,
> >  the action is performed. The action predicate may return with success.
> > --
> > 2.4.5
> 
> Applied

I'm sorry I didn't notice before but this just reverts the change done
by commit 49572501664d ("iproute2: clarification of various man8 pages").
IMHO the problem is that both versions are equally confusing as the word
"priority" can be understood in two different senses.

How about more explicit formulation, e.g.

  ... in order of decreasing logical priority (i.e. increasing numeric
  values).

Would that be better?

Michal Kubecek