netdev - Re: [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a0f8bfd-97d2-1e08-7ad7-b5791cb4312c@mojatatu.com>
Date:   Thu, 8 Sep 2016 06:38:38 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, daniel@...earbox.net,
        xiyou.wangcong@...il.com,
        John Fastabend <john.r.fastabend@...el.com>
Subject: Re: [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action

On 16-09-06 10:25 AM, Eric Dumazet wrote:

>
> Just use u16 in the array ?
>
> u16 tmpaddr[ETH_ALEN / 2]; /* ether_addr_copy() requirement */
>
> ether_addr_copy((u8 *)tmpaddr, eth_hdr(skb)->h_dest);
> ...
>

Ok - thanks Eric. BTW:
Nobody has answered my other question:
I can get stats to increment with:
bstats_update(&d->tcf_bstats, skb);
but not:
bstats_cpu_update(this_cpu_ptr(d->common.cpu_bstats), skb);

Note, test is on a VM.

cheers,
jamal