netdev - Re: [PATCH 3/4] net: phy: Add read driver for Microsemi PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160908134026.GI26445@lunn.ch>
Date:   Thu, 8 Sep 2016 15:40:26 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Raju Lakkaraju <Raju.Lakkaraju@...rosemi.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        Allan Nielsen <Allan.Nielsen@...rosemi.com>
Subject: Re: [PATCH 3/4] net: phy: Add read driver for Microsemi PHYs.

> Microsemi PHY have different pages i.e. Std IEEE, Extended,
> Extended_2, Extended_3 and GPIO pages.

Yes, nothing special there. Marvell does the same, and probably
others.

> When I want to use SIOCGMIIREG, I can read Std IEEE only with
> SIOCGMIIREG and not other pages.

So this is purely for your own debug. So you can hack in anything you
want. Just don't submit it for mainline.

Or you can do it properly. Take a look at the sources for
mii-tool. Figure out a way to do it cleanly which will work for all
phys which support multiple pages. Then submit patches which does this
for both your own PHY and one other manufacture. I can help with
Marvell PHYS, if that is what you want.

What will never get accepted is something which is not generic. What
you submit must work for multiple vendors, and you need to submit it
all, from the userspace/kernel space API all the way down to the PHY,
and ideally patches to mii-tool as well.

    Andrew