lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Sep 2016 08:47:39 -0700 From: John Fastabend <john.fastabend@...il.com> To: Eric Dumazet <eric.dumazet@...il.com>, David Miller <davem@...emloft.net> Cc: Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org, jhs@...atatu.com, Hadar Hen Zion <hadarh@...lanox.com>, Amir Vadai <amirva@...lanox.com> Subject: Re: [PATCH net] net_sched: act_mirred: full rcu conversion On 16-09-08 08:35 AM, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@...gle.com> > > As reported by Cong Wang, I was lazy when I did initial RCU conversion > of tc_mirred, as I thought I could avoid allocation/freeing of a > parameter block. > > Use an intermediate object so that fast path can get a consistent > snapshot of multiple variables (dev, action, eaction, ok_push) > > Fixes: 2ee22a90c7af ("net_sched: act_mirred: remove spinlock in fast path") > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > Reported-by: Cong Wang <xiyou.wangcong@...il.com> > Cc: John Fastabend <john.fastabend@...il.com> > Cc: Jamal Hadi Salim <jhs@...atatu.com> > Cc: Hadar Hen Zion <hadarh@...lanox.com> > Cc: Amir Vadai <amirva@...lanox.com> > --- Works for me. FWIW I find this plenty straightforward and don't really see the need to make the hash table itself rcu friendly. Acked-by: John Fastabend <john.r.fastabend@...el.com>
Powered by blists - more mailing lists