netdev - Re: [PATCH] net: ip, diag -- Add diag interface for raw sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 23:17:31 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     NETDEV <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        James Morris <jmorris@...ei.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Patrick McHardy <kaber@...sh.net>,
        Andrey Vagin <avagin@...nvz.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH] net: ip, diag -- Add diag interface for raw sockets

On Fri, Sep 09, 2016 at 12:55:13PM -0700, Eric Dumazet wrote:
> > +
> > +	rep = nlmsg_new(sizeof(struct inet_diag_msg) +
> > +			sizeof(struct inet_diag_meminfo) + 64,
> > +			GFP_KERNEL);
> > +	if (!rep)
> 
> There is a missing sock_put(sk)
> 
> > +		return -ENOMEM;
> > +
> > +	err = inet_sk_diag_fill(sk, NULL, rep, r,
> > +				sk_user_ns(NETLINK_CB(in_skb).sk),
> > +				NETLINK_CB(in_skb).portid,
> > +				nlh->nlmsg_seq, 0, nlh);
> 
> sock_put(sk);

Oh, missed. Thanks lot, Eric, will update!