netdev - Re: [PATCH net-next v3] net: inet: diag: expose the socket mark to privileged processes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 14:23:29 +0900
From:   Lorenzo Colitti <lorenzo@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        David Ahern <dsa@...ulusnetworks.com>,
        Erik Kline <ek@...gle.com>
Subject: Re: [PATCH net-next v3] net: inet: diag: expose the socket mark to
 privileged processes.

On Fri, Sep 9, 2016 at 9:57 AM, David Miller <davem@...emloft.net> wrote:
>
> > I'll see if I can send something out to pass in in_skb instead.
>
> The other option is to have a "struct foo_info" object on the callers
> stack that holds all of these values, then pass a pointer to the foo_info
> to inet_sk_diag_fill.

RFC patch sent out as http://patchwork.ozlabs.org/patch/667892/ . This
achieves a fair bit of simplification with no or negligible
performance impact, because there was a lot of redundancy in the
parameters that were passed in.

Further simplification could be achieved by removing the "bool
net_admin" parameter. I didn't do this in this patch because I don't
know the performance impact of calling netlink_ns_capable once per
socket instead of once per dump. My guess is that that's in the noise
given that we're already doing lots of copying; if it is, I can send
out a v2 that removes the net_admin parameter as well.

Didn't try the struct since this seemed a good starting point. It
could be done later, of course.