netdev - Re: [PATCH net-next v4] gso: Support partial splitting at the frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 08:46:45 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Alexander Duyck <alexander.duyck@...il.com>
CC:     Netdev <netdev@...r.kernel.org>,
        Alexander Duyck <alexander.h.duyck@...el.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        "Marcelo Ricardo Leitner" <marcelo.leitner@...il.com>
Subject: Re: [PATCH net-next v4] gso: Support partial splitting at the
 frag_list pointer

On Thu, Sep 08, 2016 at 08:37:47AM -0700, Alexander Duyck wrote:
> 
> A few minor things.
> 
> First you somehow got a couple spaces in the line before gso_size.
> That is why the two lines above don't line up.
> 
> Second it occurred to me that we could have a situation where tail is
> equal to segs in the case of GSO_PARTIAL with an MSS aligned frame.
> To avoid doing duplicate division we might want to make the else an
> "else if (tail != segs)"
> 
> Finally I think the value for the division should be tail->len -
> doffset, not tail->len as we shouldn't include the header data in the
> size as it might cause us to report more packets then we actually
> generate.
> 
> I think that should cover all of it.  Sorry for the thrash.

Never mind, I do a v5. Better one more iteration of review than a
suboptimal patch.