netdev - Re: [PATCH] xfrm_user: propagate sec ctx allocation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 10:34:56 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Mathias Krause <minipli@...glemail.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        <netdev@...r.kernel.org>, Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH] xfrm_user: propagate sec ctx allocation errors

On Thu, Sep 08, 2016 at 06:09:57PM +0200, Mathias Krause wrote:
> When we fail to attach the security context in xfrm_state_construct()
> we'll return 0 as error value which, in turn, will wrongly claim success
> to userland when, in fact, we won't be adding / updating the XFRM state.
> 
> This is a regression introduced by commit fd21150a0fe1 ("[XFRM] netlink:
> Inline attach_encap_tmpl(), attach_sec_ctx(), and attach_one_addr()").
> 
> Fix it by propagating the error returned by security_xfrm_state_alloc()
> in this case.
> 
> Fixes: fd21150a0fe1 ("[XFRM] netlink: Inline attach_encap_tmpl()...")
> Signed-off-by: Mathias Krause <minipli@...glemail.com>

Applied to the ipsec tree, thanks Mathias!