netdev - Re: [PATCH next 3/3] ipvlan: Introduce l3s mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c134452-368e-96f9-c0b1-0f6d2e507bc5@cumulusnetworks.com>
Date:   Sat, 10 Sep 2016 10:25:27 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Mahesh Bandewar (महेश बंडेवार) <maheshb@...gle.com>
Cc:     Mahesh Bandewar <mahesh@...dewar.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH next 3/3] ipvlan: Introduce l3s mode

On 9/9/16 4:46 PM, Mahesh Bandewar (महेश बंडेवार) wrote:
> On Fri, Sep 9, 2016 at 3:26 PM, David Ahern <dsa@...ulusnetworks.com> wrote:
>> On 9/9/16 3:53 PM, Mahesh Bandewar wrote:
>>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>>> index 0c5415b05ea9..95edd1737ab5 100644
>>> --- a/drivers/net/Kconfig
>>> +++ b/drivers/net/Kconfig
>>> @@ -149,6 +149,7 @@ config IPVLAN
>>>      tristate "IP-VLAN support"
>>>      depends on INET
>>>      depends on IPV6
>>> +    select NET_L3_MASTER_DEV
>>
>> depends on instead of select?
> 
> The kbuild/kconfig-language.txt suggests that for "depends on" the
> option _must_ be selected otherwise menuconfig wont even present the
> dependent option while select positively sets the option.

understood. VRF driver uses 'depends on'