netdev - Re: [PATCH] net: x25: remove null checks on arrays calling_ae and called

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160909.181536.1766927673226492239.davem@davemloft.net>
Date:   Fri, 09 Sep 2016 18:15:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     andrew.hendry@...il.com, linux-x25@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: x25: remove null checks on arrays calling_ae and
 called_ae

From: Colin King <colin.king@...onical.com>
Date: Thu,  8 Sep 2016 08:42:06 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> dtefacs.calling_ae and called_ae are both 20 element __u8 arrays and
> cannot be null and hence are redundant checks. Remove these.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Indeed, and if they were pointers they would be in userspace and would
need proper uaccess handling.

Applied to net-next, thanks.