netdev - Re: [PATCH 23/26] sh_eth: constify local structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb443416-4fb9-5593-2529-66211299c9a8@cogentembedded.com>
Date:   Sun, 11 Sep 2016 21:14:13 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     joe@...ches.com, kernel-janitors@...r.kernel.org,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 23/26] sh_eth: constify local structures

On 09/11/2016 04:06 PM, Julia Lawall wrote:
> For structure types defined in the same file or local header files, find
> top-level static structure declarations that have the following
> properties:
> 1. Never reassigned.

   Really?

> 2. Address never taken

   Really?

> 3. Not passed to a top-level macro call
> 4. No pointer or array-typed field passed to a function or stored in a
> variable.
> Declare structures having all of these properties as const.
>
> Done using Coccinelle.
> Based on a suggestion by Joe Perches <joe@...ches.com>.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

    NAK, see sh_eth_set_default_cpu_data().

MBR, Sergei